[
https://issues.apache.org/jira/browse/FLINK-11090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717050#comment-16717050
]
ASF GitHub Bot commented on FLINK-11090:
----------------------------------------
aljoscha commented on issue #7274: [FLINK-11090][streaming api] Remove unused
parameter in WindowedStream.aggregate()
URL: https://github.com/apache/flink/pull/7274#issuecomment-446190218
Thanks @hequn8128, I merged this! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unused parameter in WindowedStream.aggregate()
> ----------------------------------------------
>
> Key: FLINK-11090
> URL: https://issues.apache.org/jira/browse/FLINK-11090
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> The {{aggregateResultType}} parameter in {{WindowedStream.aggregate()}} seems
> useless. Or what have I missed?
> If it is useless, I prefer to remove the parameter by adding a new API and
> deprecate the current one. We can't remove it directly as it is
> PublicEvolving.
> {code:java}
> @PublicEvolving
> public <ACC, V, R> SingleOutputStreamOperator<R> aggregate(
> AggregateFunction<T, ACC, V> aggregateFunction,
> ProcessWindowFunction<V, R, K, W> windowFunction,
> TypeInformation<ACC> accumulatorType,
> TypeInformation<V> aggregateResultType,
> TypeInformation<R> resultType) {
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
