azagrebin commented on a change in pull request #7288: [FLINK-9702] Improvement in (de)serialization of keys and values for RocksDB state URL: https://github.com/apache/flink/pull/7288#discussion_r241709684
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java ########## @@ -129,30 +126,78 @@ public void setCurrentNamespace(N namespace) { final TypeSerializer<N> safeNamespaceSerializer, final TypeSerializer<V> safeValueSerializer) throws Exception { - Preconditions.checkNotNull(serializedKeyAndNamespace); Review comment: also here @nonnull for function args? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services