pnowojski commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r241809269
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
##########
@@ -224,14 +226,14 @@ case class ProctimeAttribute(expr: Expression) extends
TimeAttribute(expr) {
override def toString: String = s"proctime($child)"
}
-case class Key(child: Expression) extends UnaryExpression {
- override private[flink] def resultType: TypeInformation[_] = child.resultType
-
- override private[flink] def toRexNode(implicit relBuilder: RelBuilder):
RexNode = {
- throw new UnsupportedOperationException(
- s"Key Expression can only be used during table initialization.")
- }
-}
+//case class Key(child: Expression) extends UnaryExpression {
Review comment:
Some left overs to remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
