pnowojski commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r247957706
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/StreamTableEnvironmentTest.scala
##########
@@ -185,4 +198,20 @@ class StreamTableEnvironmentTest extends TableTestBase {
(jTEnv, ds)
}
+ private def prepareKeyedSchemaExpressionParser:
+ (JStreamTableEnv, DataStream[JTuple2[JBool, JTuple5[JLong, JInt, String,
JInt, JLong]]]) = {
+
+ val jStreamExecEnv = mock(classOf[JStreamExecEnv])
Review comment:
Do not use mockito here, please implement a proper mock or use actual
implementation. There are already at least couple of dummy mocks for this class
in our code base - you could deduplicate them and put one
`DummyStreamExecutionEnvironment` test jar of `flink-streaming-java` or
something along those lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
