azagrebin commented on a change in pull request #7351: [FLINK-11008][State
Backends, Checkpointing]SpeedUp upload state files using multithread
URL: https://github.com/apache/flink/pull/7351#discussion_r244004144
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -714,6 +729,20 @@ public void setNumberOfRestoringThreads(int
numberOfRestoringThreads) {
this.numberOfRestoringThreads = numberOfRestoringThreads;
}
+ /**
+ * Gets the thread number will used for uploading files to DFS when
snapshot.
Review comment:
`The number of threads used to upload files to DFS while snapshotting`
Can you please change the comment the same way for
`getNumberOfRestoringThreads` and add similar comments for the corresponding
setter methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
