azagrebin commented on a change in pull request #7351: [FLINK-11008][State Backends, Checkpointing]SpeedUp upload state files using multithread URL: https://github.com/apache/flink/pull/7351#discussion_r246334980
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java ########## @@ -428,57 +433,25 @@ private void uploadSstFiles( stateHandleID, new PlaceholderStreamStateHandle()); } else { - sstFiles.put(stateHandleID, uploadLocalFileToCheckpointFs(filePath)); + sstFilePaths.put(stateHandleID, filePath); Review comment: Same for this loop which creates `sstFilePaths/miscFilePaths`, it could be in another function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services