hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246736573
########## File path: docs/dev/connectors/filesystem_sink.md ########## @@ -117,11 +117,12 @@ input.addSink(sink); </div> <div data-lang="scala" markdown="1"> {% highlight scala %} -val input: DataStream[Tuple2[IntWritable, Text]] = ... +import org.apache.flink.api.java.tuple.Tuple2 +val input: DataStream[Tuple2[A, B]] = ??? //we need to use java Tuple2 for the SequenceFileWriter Review comment: Add a blank before `we`. Not sure about the comment. How about: Use java Tuple2 if we want to use SequenceFileWriter. We can also wait suggestions from the other reviewers. Thank you very much for the fix and update. Best, Hequn ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services