hequn8128 commented on a change in pull request #7418: FLINK-11053
Documentation - update scala sample code for bucketing sink according
URL: https://github.com/apache/flink/pull/7418#discussion_r246739676
##########
File path: docs/dev/connectors/filesystem_sink.md
##########
@@ -105,8 +105,8 @@ Example:
{% highlight java %}
DataStream<Tuple2<IntWritable,Text>> input = ...;
-BucketingSink<String> sink = new BucketingSink<String>("/base/path");
-sink.setBucketer(new DateTimeBucketer<String>("yyyy-MM-dd--HHmm",
ZoneId.of("America/Los_Angeles")));
+BucketingSink<Tuple2<IntWritable,Text>> sink = new
BucketingSink<Tuple2<IntWritable,Text>>("/base/path");
+sink.setBucketer(new DateTimeBuckete("yyyy-MM-dd--HHmm",
ZoneId.of("America/Los_Angeles")));
Review comment:
DateTimeBuckete => DateTimeBucketer.
Maybe we should write `new DateTimeBucketer<>("yyyy-MM-dd--HHmm",
ZoneId.of("America/Los_Angeles"))` to avoid unchecked assignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
