alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249606803
########## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java ########## @@ -251,6 +269,18 @@ public FlinkKafkaConsumerBase( // Configuration // ------------------------------------------------------------------------ + /** + * Make sure that auto commit is disabled when our offset commit mode is ON_CHECKPOINTS. + * This overwrites whatever setting the user configured in the properties. + * @param properties - Kafka configuration properties to be adjusted + * @param offsetCommitMode offset commit mode + */ + protected static void adjustAutoCommitConfig(Properties properties, OffsetCommitMode offsetCommitMode) { Review comment: Pushed 3cfda16 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services