alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249798168
########## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java ########## @@ -370,8 +370,8 @@ else if (partitionsRemoved) { keyPayload.get(keyBytes); } - final T value = deserializer.deserialize(keyBytes, valueBytes, - currentPartition.getTopic(), currentPartition.getPartition(), offset); + final T value = deserializer.deserialize( Review comment: Methods of 0.8 Consumer have different signatures compared to modern Kafka - namely they throw base Exception. 1. Change signature of deserialize(ConsumerRecord) to throw Exception instead of IOException. 2. Wrap and re-throw in every deserialize(ConsumerRecord) implementation which is 0.8 or for Kafka-base (KeyedDeserializationSchemaWrapper, JSONKeyValueDeserializationSchema, NonContinousOffsetsDeserializationSchema and TypeInformationKeyValueSerializationSchema) @azagrebin, @stevenzwu which approach do you prefer? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services