pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r253554512
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala ########## @@ -19,18 +19,49 @@ package org.apache.flink.table.plan.nodes import org.apache.calcite.plan.{RelOptCost, RelOptPlanner} +import org.apache.calcite.rel.core.Calc import org.apache.calcite.rel.metadata.RelMdUtil import org.apache.calcite.rex._ +import org.apache.calcite.sql.SqlKind import org.apache.flink.api.common.functions.Function import org.apache.flink.table.api.TableConfig import org.apache.flink.table.codegen.{FunctionCodeGenerator, GeneratedFunction} import org.apache.flink.table.plan.schema.RowSchema import org.apache.flink.types.Row import scala.collection.JavaConverters._ +import scala.collection.JavaConversions._ trait CommonCalc { + /** + * Returns empty if output field is not forwarded from the input for the calc. + */ + private[flink] def getInputFromOutputName(calc: Calc, outputFieldName: String): Option[String] = { Review comment: Could you add a simple unit test for this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services