pnowojski commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r253778196
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
##########
@@ -426,7 +426,7 @@ abstract class StreamTableEnvironment(
converterFunction match {
case Some(func) =>
- new CRowMapRunner[OUT](func.name, func.code, func.returnType)
+ new CRowToExternalTypeMapRunner[OUT](func.name, func.code,
func.returnType)
Review comment:
You can keep this rename and class moving as a separate `[hotfix]` commit
either at the beginning or at the end of this PR or as separate PR :) We do not
have to drop those changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
