Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1048#discussion_r38078076
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -177,9 +176,18 @@ public static SerializedJobExecutionResult 
submitJobAndWait(
                        throw new JobTimeoutException(jobGraph.getJobID(), 
"Timeout while waiting for JobManager answer. " +
                                        "Job time exceeded " + 
AkkaUtils.INF_TIMEOUT(), e);
                }
    -           catch (Throwable t) {
    +           catch(SerializedThrowable serializedThrowable) {
    +                   Throwable deserialized = 
SerializedThrowable.get(serializedThrowable, userCodeClassloader);
    +                   if(deserialized instanceof JobExecutionException) {
    +                           // no need to wrap the Throwable into a 
JobExecutionException again.
    +                           throw (JobExecutionException)deserialized;
    +                   }
    +                   throw new JobExecutionException(jobGraph.getJobID(),
    --- End diff --
    
    Can we put this statement in an `else` branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to