Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1048#discussion_r38078400
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -349,27 +351,29 @@ class JobManager(
case JobStatus.CANCELED =>
jobInfo.client ! decorateMessage(
- Failure(
- new JobCancellationException(
- jobID,
- "Job was cancelled.", error)
+ Failure(new SerializedThrowable(
+ new JobCancellationException(
+ jobID,
+ "Job was cancelled.", deserializedError)
+ )
)
)
case JobStatus.FAILED =>
jobInfo.client ! decorateMessage(
- Failure(
- new JobExecutionException(
- jobID,
- "Job execution failed.",
- error)
+ Failure(new SerializedThrowable(
+ new JobExecutionException(
+ jobID,
+ "Job execution failed.",
+ deserializedError)
+ )
)
)
case x =>
val exception = new JobExecutionException(jobID, s"$x is
not a " +
"terminal state.")
- jobInfo.client ! decorateMessage(Failure(exception))
+ jobInfo.client ! decorateMessage(Failure(new
SerializedThrowable(exception)))
--- End diff --
Do we really need to serialize the `JobExecutionException` in a
`SerializedThrowable` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
