tillrohrmann commented on a change in pull request #7662: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
(rebased)
URL: https://github.com/apache/flink/pull/7662#discussion_r256849683
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexCancelTest.java
##########
@@ -357,11 +355,8 @@ public void testActionsWhileCancelling() {
AkkaUtils.getDefaultTimeout());
setVertexState(vertex,
ExecutionState.CANCELING);
- vertex.scheduleForExecution(
- new TestingSlotProvider(ignore -> new
CompletableFuture<>()),
- false,
- LocationPreferenceConstraint.ALL,
- Collections.emptySet());
+ Scheduler scheduler = mock(Scheduler.class);
+ vertex.scheduleForExecution(scheduler, false,
LocationPreferenceConstraint.ALL, Collections.emptySet());
Review comment:
We could avoid the mock by using the `ProgrammedSlotProvider` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
