tillrohrmann commented on a change in pull request #7662: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
(rebased)
URL: https://github.com/apache/flink/pull/7662#discussion_r256871460
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -525,12 +525,12 @@ public void setInitialState(@Nullable
JobManagerTaskRestore taskRestore) {
slotProvider.allocateSlot(
Review comment:
I think callbacks on the `logicalSlotFuture` no longer need to be executed
in the main thread executor, because the `logicalSlotFuture` should be
completed by the main thread. This should affect line `Execution.java:548`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
