pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262485390
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java ########## @@ -210,10 +354,12 @@ public void testBroadcastEventNoRecords() throws Exception { } TestPooledBufferProvider bufferProvider = new TestPooledBufferProvider(Integer.MAX_VALUE, bufferSize); - ResultPartitionWriter partitionWriter = new CollectingPartitionWriter(queues, bufferProvider); - RecordWriter<ByteArrayIO> writer = new RecordWriter<>(partitionWriter); - CheckpointBarrier barrier = new CheckpointBarrier(Integer.MAX_VALUE + 919192L, Integer.MAX_VALUE + 18828228L, CheckpointOptions.forCheckpointWithDefaultLocation()); + RecordWriter<?> writer = isBroadcastWriter ? + RecordWriter.createRecordWriter(partitionWriter, new OutputEmitter(ShipStrategyType.BROADCAST, 0), "test") : + RecordWriter.createRecordWriter(partitionWriter); + + CheckpointBarrier barrier = new CheckpointBarrier(0, 0, CheckpointOptions.forCheckpointWithDefaultLocation()); Review comment: Why have you changed the constants to `0`? Was there some reason behind that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services