pnowojski commented on a change in pull request #7713: [FLINK-10995][network]
Copy intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r263563494
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java
##########
@@ -44,4 +52,67 @@ public BroadcastRecordWriter(
public void emit(T record) throws IOException, InterruptedException {
broadcastEmit(record);
}
+
+ @Override
+ public void broadcastEmit(T record) throws IOException,
InterruptedException {
Review comment:
> Considering initiating BufferConsumer#currentReaderPosition to
LatencyMarker.size() for other channels in BroadcastRecordWriter#randomEmit, I
meant this way of getting marker size seems coupled with LatencyMarker
currently.
We don't have to hardcode `LatencyMarker.size()`. After all when we were
about to set the offset, we have just serialized the record for `randomEmit()`
to a fresh `BufferBuilder` :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
