zhijiangW commented on a change in pull request #7713: [FLINK-10995][network]
Copy intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r262789933
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
##########
@@ -196,10 +198,152 @@ public void testSerializerClearedAfterClearBuffers()
throws Exception {
}
/**
- * Tests broadcasting events when no records have been emitted yet.
+ * Tests broadcasting events when no records have been emitted yet in
{@link BroadcastRecordWriter}.
*/
@Test
- public void testBroadcastEventNoRecords() throws Exception {
+ public void testBroadcastWriterBroadcastEventNoRecord() throws
Exception {
Review comment:
I considered this way before and also preferred it actually.
But I wonder maybe not all the existing tests in `RecordWriterTest` are
necessary for executing in `BroadcastRecordWriter`, like
`testClearBuffersAfterInterruptDuringBlockingBufferRequest` and
`testSerializerClearedAfterClearBuffers` which I have not touched before. Then
I only added the broadcast modes for the other existing tests.
I would double check and try to refactor the tests in a separate
`BroadcastRecordWriterTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
