JingsongLi commented on a change in pull request #7958:
[FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink
table
URL: https://github.com/apache/flink/pull/7958#discussion_r264528994
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/generated/GeneratedClass.java
##########
@@ -49,7 +49,9 @@ protected GeneratedClass(String className, String code,
Object[] references) {
@SuppressWarnings("unchecked")
public T newInstance(ClassLoader classLoader) {
try {
- return (T)
compile(classLoader).getConstructor(Object[].class).newInstance(references);
+ return (T)
compile(classLoader).getConstructor(Object[].class)
+ // newInstance(Object ... initargs)
Review comment:
Because Constructor.newInstance(Object... initargs), we need to load
references into a new Object[], otherwise it cannot be compiled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
