JingsongLi commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#discussion_r264529901
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryGeneric.java ########## @@ -79,4 +79,16 @@ public void materialize() { int offset = (int) (offsetAndSize >> 32); return new BinaryGeneric<>(segments, offset + baseOffset, size, null); } + + public static <T> T getJavaObjectFromBinaryGeneric(BinaryGeneric<T> value, TypeSerializer<T> ser) { + if (value.getJavaObject() == null) { + try { + value.setJavaObject(InstantiationUtil.deserializeFromByteArray(ser, + SegmentsUtil.copyToBytes(value.getSegments(), value.getOffset(), value.getSizeInBytes()))); + } catch (IOException e) { + throw new RuntimeException(e); Review comment: To avoid external code paths need capture IOException. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services