hequn8128 commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r275209599
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala
##########
@@ -80,7 +80,7 @@ class DataStreamWindowJoinRule
leftRowSchema.arity,
join.getRowType,
join.getCluster.getRexBuilder,
- TableConfig.DEFAULT)
Review comment:
The `DEFAULT` in scala is actually a method. We need to create each time
because the tableConfig could be modified in anyplace.
To make it more convenient, maybe we can add a static `getDefault()` method
in `TableConfig`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
