hequn8128 commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r276222599
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/sources/tsextractors/ExistingField.scala
##########
@@ -75,4 +78,11 @@ final class ExistingField(val field: String) extends
TimestampExtractor {
override def hashCode(): Int = {
field.hashCode
}
+
+ override def toProperties: util.Map[String, String] = {
+ val javaMap = new util.HashMap[String, String]()
+ javaMap.put(Rowtime.ROWTIME_TIMESTAMPS_TYPE,
Rowtime.ROWTIME_TIMESTAMPS_TYPE_VALUE_FROM_FIELD)
+ javaMap.put(Rowtime.ROWTIME_TIMESTAMPS_FROM,
this.getArgumentFields.apply(0))
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
