GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280423763
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/EagerSchedulingStrategy.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.io.network.partition.ResultPartitionID; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.scheduler.DeploymentOption; +import org.apache.flink.runtime.scheduler.ExecutionVertexDeploymentOption; +import org.apache.flink.runtime.scheduler.SchedulerOperations; + +import java.util.ArrayList; +import java.util.List; +import java.util.Set; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * {@link SchedulingStrategy} instance for streaming job which will schedule all tasks at the same time. + */ +public class EagerSchedulingStrategy implements SchedulingStrategy { + + private final SchedulerOperations schedulerOperations; + + private final SchedulingTopology schedulingTopology; + + private final DeploymentOption deploymentOption = new DeploymentOption(false); + + public EagerSchedulingStrategy( + SchedulerOperations schedulerOperations, + SchedulingTopology schedulingTopology, + JobGraph jobGraph) { + this.schedulerOperations = checkNotNull(schedulerOperations); + this.schedulingTopology = checkNotNull(schedulingTopology); + } + + @Override + public void startScheduling() { + // Schedule all the vertices in scheduling topology at the same time. + List<ExecutionVertexDeploymentOption> executionVertexDeploymentOptions = new ArrayList<>(); Review comment: Some code from here is duplicated in `restartTasks`. I would propose to split the methods into smaller units, e.g.,: ``` @Override public void startScheduling() { final Set<ExecutionVertexID> allVertices = getAllVerticesFromTopology(); allocateSlotsAndDeploy(allVertices); } @Override public void restartTasks(Set<ExecutionVertexID> verticesNeedingRestart) { allocateSlotsAndDeploy(verticesNeedingRestart); } private Set<ExecutionVertexID> getAllVerticesFromTopology() { return StreamSupport .stream(schedulingTopology.getVertices().spliterator(), false) .map(SchedulingVertex::getId) .collect(Collectors.toSet()); } private void allocateSlotsAndDeploy(final Set<ExecutionVertexID> allVertices) { final List<ExecutionVertexDeploymentOption> executionVertexDeploymentOptions = createExecutionVertexDeploymentOptions(allVertices); schedulerOperations.allocateSlotsAndDeploy(executionVertexDeploymentOptions); } private List<ExecutionVertexDeploymentOption> createExecutionVertexDeploymentOptions(final Iterable<ExecutionVertexID> verticesNeedingRestart) { List<ExecutionVertexDeploymentOption> executionVertexDeploymentOptions = new ArrayList<>(); for (ExecutionVertexID executionVertexID : verticesNeedingRestart) { executionVertexDeploymentOptions.add( new ExecutionVertexDeploymentOption(executionVertexID, deploymentOption)); } return executionVertexDeploymentOptions; } ``` Feel free to adapt my proposal to your liking. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
