GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279728912
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/TestingSchedulingVertex.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.jobgraph.JobVertexID; + +import java.util.Collection; + +/** + * A Simple scheduling vertex for testing purposes. + */ +public class TestingSchedulingVertex implements SchedulingVertex { + + private final ExecutionVertexID executionVertexId; + + public TestingSchedulingVertex(JobVertexID jobVertexId, int subtaskIndex) { + this.executionVertexId = new ExecutionVertexID(jobVertexId, subtaskIndex); + } + + @Override + public ExecutionVertexID getId() { + return executionVertexId; + } + + @Override + public ExecutionState getState() { + return ExecutionState.CREATED; + } + + @Override + public JobVertexID getJobVertexId() { + return executionVertexId.getJobVertexId(); + } + + @Override + public Collection<SchedulingResultPartition> getConsumedResultPartitions() { + return null; Review comment: To avoid handling `null` as a special case, we should just return `Collections.emptyList()` if there are no `SchedulingResultPartitions`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services