sunjincheng121 commented on a change in pull request #8311:
[FLINK-10976][table] Add Aggregate operator to Table API
URL: https://github.com/apache/flink/pull/8311#discussion_r281128559
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/operations/OperationTreeBuilder.scala
##########
@@ -160,11 +159,61 @@ class OperationTreeBuilder(private val tableEnv:
TableEnvImpl) {
aggregateOperationFactory.createAggregate(resolvedGroupings,
resolvedAggregates, child)
}
+ def rowBasedAggregate(
Review comment:
I think we can `rowBasedAggregate` -> `aggregate` and add some comments to
illustrate the difference between the two aggregate methods, What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
