sunjincheng121 commented on a change in pull request #8311:
[FLINK-10976][table] Add Aggregate operator to Table API
URL: https://github.com/apache/flink/pull/8311#discussion_r281124933
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -503,6 +511,14 @@ class GroupedTableImpl(
))
}
+ override def aggregate(aggregateFunction: String): AggregatedTable = {
+ aggregate(ExpressionParser.parseExpression(aggregateFunction))
+ }
+
+ override def aggregate(aggregateFunction: Expression): AggregatedTable = {
Review comment:
Can we consistency the name format for `aggregateFunction` and
`tableAggFunction`?
I suggest using the complete word, i.e.: `Agg`->`Aggregate`? What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
