pnowojski commented on a change in pull request #8559: [FLINK-12576][Network,
Metrics]Take localInputChannel into account when complute inputQueueLength
URL: https://github.com/apache/flink/pull/8559#discussion_r288573440
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionReader.java
##########
@@ -135,6 +135,11 @@ public Throwable getFailureCause() {
return null;
}
+ @Override
+ public int unsafeGetSizeOfQueuedBuffer() {
+ return parent.unsynchronizedGetNumberOfQueuedBuffers();
Review comment:
I think this currently always returns `0`. Could you add a description to
`flink/docs/monitoring/metrics.md` that `inputQueueLength`:
> ignores `LocalInputChannels` which are using blocking subpartitions.
I have also created a ticket for this:
https://issues.apache.org/jira/browse/FLINK-12674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
