pnowojski commented on a change in pull request #8559: [FLINK-12576][Network,
Metrics]Take localInputChannel into account when complute inputQueueLength
URL: https://github.com/apache/flink/pull/8559#discussion_r288576224
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -260,6 +260,18 @@ void releaseAllResources() throws IOException {
}
}
+ int unSafeGetSizeOfQueuedBuffer() {
Review comment:
Can we extract this and
`RemoteInputChannel#unsynchronizedGetNumberOfQueuedBuffers` to `InputChannel`
interface? Thanks to that, we will not need to `instance of` check in the
`SingleInputGate` + can you add test coverage for this in
`LocalInputChannelTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
