Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors]
StringWriter support custom row delimiter
URL: https://github.com/apache/flink/pull/8571#discussion_r288931942
##########
File path:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/StringWriter.java
##########
@@ -40,12 +40,15 @@
private transient Charset charset;
+ private byte[] rowDelimiter ;
+
+
/**
* Creates a new {@code StringWriter} that uses {@code "UTF-8"} charset
to convert
* strings to bytes.
*/
public StringWriter() {
- this("UTF-8");
+ this("UTF-8",new byte[] {'\n'});
Review comment:
There should exist a space before `new byte[] {'\n'}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
