Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8571#discussion_r291866487
########## File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/StringWriter.java ########## @@ -82,7 +87,7 @@ public void open(FileSystem fs, Path path) throws IOException { public void write(T element) throws IOException { FSDataOutputStream outputStream = getStream(); outputStream.write(element.toString().getBytes(charset)); - outputStream.write('\n'); + outputStream.write(rowDelimiter.getBytes(charset)); Review comment: Sorry for late reply, I noticed that you have addressed all my suggestions on the new PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services