zentol commented on a change in pull request #8566: [FLINK-12673][network] 
Introduce NetworkEnvironment.getUnreleasedPartitions instead of using 
getResultPartitionManager
URL: https://github.com/apache/flink/pull/8566#discussion_r288950504
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
 ##########
 @@ -172,6 +173,7 @@ private static void registerNetworkMetrics(MetricGroup 
metricGroup, NetworkBuffe
        //  Properties
        // 
--------------------------------------------------------------------------------------------
 
+       @VisibleForTesting
        public ResultPartitionManager getResultPartitionManager() {
 
 Review comment:
   can this be package private?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to