zentol commented on a change in pull request #8566: [FLINK-12673][network]
Introduce NetworkEnvironment.getUnreleasedPartitions instead of using
getResultPartitionManager
URL: https://github.com/apache/flink/pull/8566#discussion_r288950412
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -201,6 +203,28 @@ public void
releasePartitions(Collection<ResultPartitionID> partitionIds) {
}
}
+ /**
+ * Report unreleased partitions.
+ *
+ * <p>Partitions are released in the following cases:
Review comment:
I don't believe this javadoc belongs on this method. It contains information
about implementation details of various methods, and thus should likely be
placed into the class javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
