twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make
the DataStream & DataSet conversion to a Table independent from Calcite
URL: https://github.com/apache/flink/pull/8521#discussion_r289283005
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetScan.scala
##########
@@ -36,15 +39,20 @@ import org.apache.flink.types.Row
class DataSetScan(
cluster: RelOptCluster,
traitSet: RelTraitSet,
- table: RelOptTable,
+ catalog: RelOptSchema,
+ inputDataSet: DataSet[_],
+ fieldIdxs: Array[Int],
rowRelDataType: RelDataType)
- extends TableScan(cluster, traitSet, table)
+ extends TableScan(
+ cluster,
+ traitSet,
+ RelOptTableImpl.create(catalog, rowRelDataType, List[String]().asJava,
null))
with BatchScan {
- val dataSetTable: DataSetTable[Any] =
getTable.unwrap(classOf[DataSetTable[Any]])
-
override def deriveRowType(): RelDataType = rowRelDataType
+ override def estimateRowCount(mq: RelMetadataQuery): Double = 1000L
Review comment:
Having this hard coded here seems weird. What was the old behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
