twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make
the DataStream & DataSet conversion to a Table independent from Calcite
URL: https://github.com/apache/flink/pull/8521#discussion_r289282600
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetScan.scala
##########
@@ -63,10 +73,11 @@ class DataSetScan(
tableEnv: BatchTableEnvImpl,
queryConfig: BatchQueryConfig): DataSet[Row] = {
val schema = new RowSchema(rowRelDataType)
- val inputDataSet: DataSet[Any] = dataSetTable.dataSet
- val fieldIdxs = dataSetTable.fieldIndexes
val config = tableEnv.getConfig
- convertToInternalRow(schema, inputDataSet, fieldIdxs, config, None)
+ convertToInternalRow(schema, inputDataSet.asInstanceOf[DataSet[Any]],
fieldIdxs, config, None)
Review comment:
nit: `DataSet[Any]` -> `DataSet[_]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
