xuefuz commented on a change in pull request #8589:
[FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for
HiveCatalog
URL: https://github.com/apache/flink/pull/8589#discussion_r289970235
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -124,7 +126,7 @@ public HiveCatalog(String catalogName, String
defaultDatabase, HiveConf hiveConf
LOG.info("Created HiveCatalog '{}'", catalogName);
}
- private static HiveConf getHiveConf(String hiveMetastoreURI) {
+ public static HiveConf getHiveConf(String hiveMetastoreURI) {
Review comment:
Instead of exposing this method, maybe we should move the logic to the
caller instead. After all, the logic is simple enough and HiveConf instance is
all HiveCatalog needs in order to connect to HMS properly. How to get HiveConf
is up to the caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
