xuefuz commented on a change in pull request #8589:
[FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for
HiveCatalog
URL: https://github.com/apache/flink/pull/8589#discussion_r291770702
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveTestUtils.java
##########
@@ -36,25 +37,34 @@
/**
* Create a HiveCatalog with an embedded Hive Metastore.
*/
- public static HiveCatalog createHiveCatalog() throws IOException {
- return new HiveCatalog(CatalogTestBase.TEST_CATALOG_NAME, null,
getHiveConf());
+ public static HiveCatalog createHiveCatalog() {
+ return createHiveCatalog(CatalogTestBase.TEST_CATALOG_NAME);
+ }
+
+ public static HiveCatalog createHiveCatalog(String catalogName) {
+ return new HiveCatalog(catalogName, null, getHiveConf());
}
public static HiveCatalog createHiveCatalog(HiveConf hiveConf) {
return new HiveCatalog(CatalogTestBase.TEST_CATALOG_NAME, null,
hiveConf);
}
- public static HiveConf getHiveConf() throws IOException {
+ public static HiveConf getHiveConf() {
Review comment:
rename to createHiveConf?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
