1u0 commented on a change in pull request #8742: [FLINK-11879] Add validators
for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#discussion_r301059195
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -337,6 +338,9 @@ public final void invoke() throws Exception {
operatorChain = new OperatorChain<>(this,
recordWriters);
headOperator = operatorChain.getHeadOperator();
+ // check environment for selective reading
+ checkSelectiveReadingEnv();
Review comment:
My main suspect was that you may not have the same environment configuration
at JM's side.
But regarding `OperatorChain.hasSelectiveReadingOperator()` implementation,
I think delegating it to JM should not add more overhead. You already have
```java
Class<?> operatorClass = operatorFactory.getStreamOperatorClass();
InputSelectable.class.isAssignableFrom(operatorClass);
```
check in
[`StreamingJobGraphGenerator`](https://github.com/apache/flink/blob/9ab0b7d3b23c8c548edd0723be34e143e144afaf/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java#L682-L683).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
