1u0 commented on a change in pull request #8742: [FLINK-11879] Add validators
for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#discussion_r301503188
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -337,6 +338,9 @@ public final void invoke() throws Exception {
operatorChain = new OperatorChain<>(this,
recordWriters);
headOperator = operatorChain.getHeadOperator();
+ // check environment for selective reading
+ checkSelectiveReadingEnv();
Review comment:
My understanding was that `StreamingJobGraphGenerator.createJobGraph()`
happens in JM side only. But it looks like it is also called at sql-client,
where you may not have the same environment configuration.
> taskmanager.network.credit-model is an option that is deprecated, and the
validation will not be needed after it is removed. So I think it's easier to
add validation here and to remove it in the future.
I'm fine with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
