wuchong commented on a change in pull request #9099:
[FLINK-13237][table-planner-blink] Add expression table api test to blink
URL: https://github.com/apache/flink/pull/9099#discussion_r309557480
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/DecimalTypeTest.scala
##########
@@ -202,22 +305,22 @@ class DecimalTypeTest extends ExpressionTestBase {
override def testData: Row = {
val testData = new Row(6)
- testData.setField(0, Decimal.castFrom("123456789.123456789123456789", 30,
18))
- testData.setField(1, Decimal.castFrom("123456789123456789123456789", 30,
0))
+ testData.setField(0, BigDecimal("123456789.123456789123456789").bigDecimal)
+ testData.setField(1, BigDecimal("123456789123456789123456789").bigDecimal)
testData.setField(2, 42)
testData.setField(3, 4.2)
- testData.setField(4, Decimal.castFrom("123456789", 10, 0))
- testData.setField(5, Decimal.castFrom("0.000", 10, 3))
+ testData.setField(4, BigDecimal("123456789").bigDecimal)
+ testData.setField(5, BigDecimal("0.000").bigDecimal)
testData
}
override def typeInfo: RowTypeInfo = {
new RowTypeInfo(
- /* 0 */ DecimalTypeInfo.of(30, 18),
- /* 1 */ DecimalTypeInfo.of(30, 0),
- /* 2 */ Types.INT,
- /* 3 */ Types.DOUBLE,
- /* 4 */ DecimalTypeInfo.of(10, 0),
- /* 5 */ DecimalTypeInfo.of(10, 3))
Review comment:
Please keep the comment index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
