wuchong commented on a change in pull request #9099:
[FLINK-13237][table-planner-blink] Add expression table api test to blink
URL: https://github.com/apache/flink/pull/9099#discussion_r309545022
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/validation/MapTypeValidationTest.scala
##########
@@ -27,16 +28,24 @@ class MapTypeValidationTest extends MapTypeTestBase {
@Test(expected = classOf[ValidationException])
def testWrongKeyType(): Unit = {
+ testAllApis('f2.at(12), "f2.at(12)", "f2[12]", "FAIL")
testSqlApi("f2[12]", "FAIL")
Review comment:
The exception test only covers the first expression. So I think we should
remove `testSqlApi("f2[12]", "FAIL")` as it has been covered
`testAllApis('f2.at(12), "f2.at(12)", "f2[12]", "FAIL")`. The same with
following tests.
Btw, `testAllApis('f2.at(12), "f2.at(12)", "f2[12]", "FAIL")` can't test all
expressions. Only the first `'f2.at(12)` is covered. We should fix that in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
