pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319830496
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1151,7 +1151,10 @@ public void run() {
FileSystemSafetyNet.setSafetyNetCloseableRegistryForThread(safetyNetCloseableRegistry);
try {
-
invokable.triggerCheckpoint(checkpointMetaData, checkpointOptions,
advanceToEndOfEventTime);
+
invokable.triggerCheckpointAsync(checkpointMetaData, checkpointOptions,
advanceToEndOfEventTime);
Review comment:
I would guess that there is only one RPC thread, however I do not see an
issue here even if they weren't? Those actions would be ordered on the mailbox,
the same way they were ordered on the `asyncCallDispatcher`. If there was a
race on the RPC thread between requests, there would be the same situation now,
just against enqueuing into a different single threaded executor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
