pnowojski commented on a change in pull request #9564: 
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox 
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r322080057
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
 ##########
 @@ -1380,6 +1398,54 @@ protected void 
performDefaultAction(DefaultActionContext context) throws Excepti
                }
        }
 
+       /**
+        * A task that checks that some StreamTask methods are called only in 
the main task's thread.
 
 Review comment:
   I would rephrase this comment and move it above `testThreadInvariants`. 
Otherwise it's quite difficult to understand what this test is suppose to do.
   
   Also could you copy paste this also as a commit message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to