xintongsong commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r327922460
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/KeyedBudget.java ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.memory; + +import org.apache.flink.types.Either; + +import javax.annotation.concurrent.GuardedBy; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Map.Entry; + +class KeyedBudget<K> { + private final Map<K, Long> maxBudgetByKey; + + @GuardedBy("lock") + private final Map<K, Long> availableBudgetByKey; + + private final Object lock = new Object(); + + KeyedBudget(Map<K, Long> maxBudgetByKey) { + this.maxBudgetByKey = new HashMap<>(maxBudgetByKey); + this.availableBudgetByKey = new HashMap<>(maxBudgetByKey); + } + + /** + * Tries to acquire budget which equals to the number of pages times page size. + * + * <p>See also {@link #acquirePagedBudgetForKeys(Iterable, long, long)} + */ + Either<Map<K, Long>, Long> acquirePagedBudget(int pageNum, long pageSize) { + return acquirePagedBudgetForKeys(maxBudgetByKey.keySet(), pageNum, pageSize); + } + + /** + * Tries to acquire budget for a given key. + * + * <p>No budget is acquired if it was not possible to fully acquire the requested budget. + * + * @param key the key to acquire budget from + * @param size the size of budget to acquire from the given key + * @return the fully acquired budget for the key or max possible budget to acquir Review comment: typo: acquir -> aquire ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
