xintongsong commented on a change in pull request #9693: [FLINK-13984] Separate 
on-heap and off-heap managed memory pools
URL: https://github.com/apache/flink/pull/9693#discussion_r327916130
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
 ##########
 @@ -288,10 +244,9 @@ public void allocatePages(Object owner, 
List<MemorySegment> target, int numPages
 
                        // in the case of pre-allocated memory, the 
'numNonAllocatedPages' is zero, in the
                        // lazy case, the 'freeSegments.size()' is zero.
 
 Review comment:
   Comments need to be updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to