hequn8128 commented on a change in pull request #9748:
[FLINK-14016][python][flink-table-planner] Introduce DataStreamPythonCalc for
Python function execution
URL: https://github.com/apache/flink/pull/9748#discussion_r327938976
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/CalciteConfig.scala
##########
@@ -52,6 +52,12 @@ class CalciteConfigBuilder {
private var replaceLogicalOptRules: Boolean = false
private var logicalOptRuleSets: List[RuleSet] = Nil
+ /**
+ * Defines the logical optimization rule set.
Review comment:
Adapt the comments. Maybe we can name this phase as `logical rewrite phase`,
same with blink. And don't name it pythonxxx, as this phase may be used by
other features.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
