hequn8128 commented on a change in pull request #9748: [FLINK-14016][python][flink-table-planner] Introduce DataStreamPythonCalc for Python function execution URL: https://github.com/apache/flink/pull/9748#discussion_r327948404
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/BatchOptimizer.scala ########## @@ -54,7 +54,8 @@ class BatchOptimizer( val decorPlan = RelDecorrelator.decorrelateQuery(expandedPlan) val normalizedPlan = optimizeNormalizeLogicalPlan(decorPlan) val logicalPlan = optimizeLogicalPlan(normalizedPlan) - optimizePhysicalPlan(logicalPlan, FlinkConventions.DATASET) + val pythonizedLogicalPlan = optimizePythonLogicalPlan(logicalPlan) Review comment: Remove the changes for bach here. Batch is not covered in this PR. If we intend to support batch, we need to add batch rules, batch node and related tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services