zhuzhurk commented on a change in pull request #9715: [FLINK-13993][runtime]
Using FlinkUserCodeClassLoaders to load the user class in the perjob mode
URL: https://github.com/apache/flink/pull/9715#discussion_r329319129
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -110,12 +121,14 @@ public JobGraph retrieveJobGraph(Configuration
configuration) throws FlinkExcept
}
}
- private PackagedProgram createPackagedProgram() throws FlinkException {
+ private PackagedProgram createPackagedProgram() throws FlinkException,
IOException {
final String entryClass = getJobClassNameOrScanClassPath();
try {
- final Class<?> mainClass =
getClass().getClassLoader().loadClass(entryClass);
- return new PackagedProgram(mainClass, programArguments);
- } catch (ClassNotFoundException | ProgramInvocationException e)
{
+ final String userClassPaths = getUserClassPaths().
+
stream().map(URL::toString).collect(Collectors.joining(":"));
Review comment:
According to the [code style
guide](https://flink.apache.org/contributing/code-style-and-quality-formatting.html#breaking-the-lines-of-too-long-statements),
each call should be in a new line when breaking long statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
