zhuzhurk commented on a change in pull request #9715: [FLINK-13993][runtime]
Using FlinkUserCodeClassLoaders to load the user class in the perjob mode
URL: https://github.com/apache/flink/pull/9715#discussion_r329320115
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
##########
@@ -77,7 +81,9 @@ private StandaloneJobClusterEntryPoint(
protected DispatcherResourceManagerComponentFactory<?>
createDispatcherResourceManagerComponentFactory(Configuration configuration) {
return new JobDispatcherResourceManagerComponentFactory(
StandaloneResourceManagerFactory.INSTANCE,
- new ClassPathJobGraphRetriever(jobId,
savepointRestoreSettings, programArguments, jobClassName));
+ new ClassPathJobGraphRetriever(jobId,
savepointRestoreSettings, programArguments, jobClassName,
+ Paths.get(System.getenv(ENV_FLINK_HOME_DIR) ==
null ? DEFAULT_FLINK_HOME : System.getenv(ENV_FLINK_HOME_DIR),
Review comment:
Hard coding "/opt/flink" looks a bit tricky.
Is it possible to we set "FLINK_HOME" in all cases? So that we can throw
exception here for unexpected cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
