GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333504071
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java ########## @@ -211,7 +215,8 @@ private Runnable restartTasks(final Set<ExecutionVertexVersion> executionVertexV } private CompletableFuture<?> cancelExecutionVertex(final ExecutionVertexID executionVertexId) { - return executionVertexOperations.cancel(getExecutionVertex(executionVertexId)); + return executionVertexOperations.cancel(getExecutionVertex(executionVertexId)) + .whenComplete((Object ignored, Throwable t) -> executionSlotAllocator.cancel(executionVertexId)); Review comment: Can you elaborate on why it is important that the slot allocation is cancelled right after `executionVertexOperations.cancel()`? Why not before? For example: ``` executionSlotAllocator.cancel(executionVertexId); return executionVertexOperations.cancel(getExecutionVertex(executionVertexId)); ``` I suppose the slot allocation cancellation is moved out of `allocateSlotsAndDeploy(...)` so that it happens earlier? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services